Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(python) Update object finalizers and add keepalives #26

Merged
merged 1 commit into from
Jun 28, 2023
Merged

(python) Update object finalizers and add keepalives #26

merged 1 commit into from
Jun 28, 2023

Conversation

andrewwhitehead
Copy link
Member

Borrows some wrapper updates from aries-askar, and replaces __del__ magic methods with finalizers.

Fixes #22

@conanoc
Copy link

conanoc commented Mar 14, 2023

I cannot review the python code. I just tested this change on the test I'd created before for #22 and it passed without any error.
You can find my crude test code here: https://gist.github.com/conanoc/5a74b581c3ea70fdae17e490966b6128

@andrewwhitehead andrewwhitehead mentioned this pull request Mar 16, 2023
Merged
@andrewwhitehead andrewwhitehead merged commit 24629a6 into hyperledger:main Jun 28, 2023
@andrewwhitehead andrewwhitehead deleted the fix/python-keepalive branch June 28, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conanoc conanoc Awaiting requested review from conanoc

@ianco ianco Awaiting requested review from ianco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python wrapper verification error when there are multiple revocation registry entries
2 participants
@andrewwhitehead @conanoc